Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EntryChunkPlugin to handle shebang and shims #399

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Nov 11, 2024

Summary

Fix #391.
Fix #381.
Fix #166.

Overview

  • Change the implementation of shim for import.meta.url. Previously, we can't use BannerPlugin to insert it into the top of the bundle as there might be a existing "use strict", inject to the end also does not help as there will be a TDZ. In thi PR, using processAssets hook to insert the shim code to the correct position while preserve the leading "use strict".
  • Preserve the leading shebang directive for chunk entry modules, the implementation refers https://github.com/shuangwhywhy/webpack-shebang-plugin.
  • Preserve the leading React directive for chunk entry modules.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 428cfa5
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/673568cf7e9dfc0008e85668
😎 Deploy Preview https://deploy-preview-399--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework fi3ework force-pushed the shebang branch 4 times, most recently from 3284409 to d5971e8 Compare November 11, 2024 18:00
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #399 will not alter performance

Comparing shebang (fa571c0) with main (d3c1c16)

Summary

✅ 5 untouched benchmarks

@fi3ework fi3ework force-pushed the shebang branch 6 times, most recently from 021b27f to db310bd Compare November 13, 2024 09:56
@fi3ework fi3ework force-pushed the shebang branch 7 times, most recently from a6ddd4d to fc198ad Compare November 14, 2024 04:55
@fi3ework fi3ework force-pushed the shebang branch 3 times, most recently from 3f6e249 to 10633d7 Compare November 14, 2024 05:52
www
@fi3ework fi3ework marked this pull request as ready for review November 14, 2024 06:03
@fi3ework fi3ework marked this pull request as draft November 14, 2024 06:03
packages/core/src/config.ts Show resolved Hide resolved
packages/plugin-dts/src/dts.ts Show resolved Hide resolved
tests/scripts/shared.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants